feat: PRT: Add subscription metrics #1695
Open
+105
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2024 15:19
lyomagma
changed the title
lyomagma
changed the title
lyomagma
changed the title
shleikes
changed the title
…dd-subscription-metrics
shleikes
requested changes
Sep 17, 2024
| @@ -190,6 +202,7 @@ func (cwsm *ConsumerWSSubscriptionManager) StartSubscription( | |||
| webSocketConnectionUniqueId string, | |||
| metricsData *metrics.RelayMetrics, | |||
| ) (firstReply *pairingtypes.RelayReply, repliesChan <-chan *pairingtypes.RelayReply, err error) { | |||
| go cwsm.rpcConsumerLogs.SetRelaySubscriptionRequestMetric(metricsData.ChainID, metricsData.APIType) | |||
There was a problem hiding this comment.
I'm not sure we want this here. Users might spam with false subscription message, which will increase this metric for nothing. Maybe move this to after validation?
Comment on lines
24
to
28
| const ( | ||
| ConsumerDisconnect RelayDisconnectReasonEnum = "ConsumerDisconnect" | ||
| ProviderDisconnect RelayDisconnectReasonEnum = "ProviderDisconnect" | ||
| UserDisconnect RelayDisconnectReasonEnum = "UserDisconnect" | ||
| ) |
There was a problem hiding this comment.
Move this to metrics, change to int enum, and use map
added 6 commits
September 17, 2024 14:21
…a into prt-add-subscription-metrics
shleikes
requested changes
Sep 19, 2024
| @@ -201,6 +204,7 @@ func (cwsm *ConsumerWSSubscriptionManager) StartSubscription( | |||
| utils.LogAttr("GUID", webSocketCtx), | |||
| utils.LogAttr("hashedParams", utils.ToHexString(hashedParams)), | |||
| utils.LogAttr("dappKey", dappKey), | |||
| utils.LogAttr("connectedDapps", cwsm.connectedDapps), | |||
There was a problem hiding this comment.
This is removed in main, why is is added back here?
Comment on lines
18
to
22
| const ( | ||
| ConsumerDisconnect WsDisconnectReasonEnum = iota | ||
| ProviderDisconnect WsDisconnectReasonEnum = iota | ||
| UserDisconnect WsDisconnectReasonEnum = iota | ||
| ) |
There was a problem hiding this comment.
- You can do the
= iotaonce in thins enum, as can be seen for example inprovider_optimizer.go - Please use upper case snake case for this enum
- Please prefix the enum items with
WS_DISCONNECTION_REASON_
Comment on lines
24
to
28
| var disconnectReasonMap = map[WsDisconnectReasonEnum]string{ | ||
| ConsumerDisconnect: "ConsumerDisconnect", | ||
| ProviderDisconnect: "ProviderDisconnect", | ||
| UserDisconnect: "UserDisconnect", | ||
| } |
There was a problem hiding this comment.
If this is only for logs, make the strings a bit more readable, like kebab-case
Comment on lines
111
to
112
| Help: "The total number of websocket subscription requests by the consumer over time per chain id per api interface.", | ||
| }, []string{"spec", "apiInterface"}) |
There was a problem hiding this comment.
Suggested change
| Help: "The total number of websocket subscription requests by the consumer over time per chain id per api interface.", | |
| }, []string{"spec", "apiInterface"}) | |
| Help: "The total number of websocket subscription requests over time per chain id per api interface.", | |
| }, []string{"spec", "apiInterface"}) |
|
|
||
| totalFailedWsSubscriptionRequestsMetric := prometheus.NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "lava_consumer_total_failed_ws_subscription_requests", | ||
| Help: "The total number of failed websocket subscription requests by the consumer over time per chain id per api interface.", |
There was a problem hiding this comment.
Suggested change
| Help: "The total number of failed websocket subscription requests by the consumer over time per chain id per api interface.", | |
| Help: "The total number of failed websocket subscription requests over time per chain id per api interface.", |
|
|
||
| totalDuplicatedWsSubscriptionRequestsMetric := prometheus.NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "lava_consumer_total_duplicated_ws_subscription_requests", | ||
| Help: "The total number of duplicated webscket subscription requests by the consumer over time per chain id per api interface.", |
There was a problem hiding this comment.
Suggested change
| Help: "The total number of duplicated webscket subscription requests by the consumer over time per chain id per api interface.", | |
| Help: "The total number of duplicated webscket subscription requests over time per chain id per api interface.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add consumer relay subscription metrics
https://github.com/orgs/Magma-Devs/projects/4/views/10?pane=issue&itemId=78426623